Reviews
For youCreated
fix(sheet): header truncation with long titles [LNUI-903]1hfix(dialog): title id collision with multiple instances [LNUI-909]6hfeat(pagination): compound component API [LNUI-622]7hfeat(docs): search by prop name and enum values [LNUI-911]1dfix(progress): label rounding at 99.5 percent [LNUI-912]1dfeat(spinner): size and stroke tokens [LNUI-914]2dfeat(dialog): inert background instead of the aria-hidden walker [LNUI-780]2dfix(combobox): popover width when the trigger sits in a grid cell [LNUI-796]3dfix(toast): announce politely instead of assertively [LNUI-798]3dfeat(button): loading prop with spinner replacement [LNUI-750]4dfeat(avatar): fallback gradient derived from the user id hash [LNUI-763]5dfeat(popover): opt-in modal mode with focus containment [LNUI-766]5dfeat(scroll-area): scroll shadows via scroll-driven animations [LNUI-760]6dchore(lib): replace lodash.debounce with an in-house scheduler [LNUI-782]1wfix(button): gap collapses when an icon-only child is conditional [LNUI-797]1wfeat(table): monospace numeric cell variant [LNUI-761]8dfeat(a11y): skip-to-content link helper for app shells [LNUI-765]10dfeat(tabs): lazy mount panels with a keepMounted opt-in [LNUI-751]12dfeat(toolbar): overflow priority API [LNUI-916]2w
LNUI-903›fix(sheet): header truncation with long titles [LNUI-903]+117-8
OverviewGuideDiff

fix(sheet): header truncation with long titles [LNUI-903]

lndev-ui#412·main ← fix/lnui-903-sheet-header-truncation
Description

Summary

  • Bug: a Sheet with a long title pushed the close button out of the header — the title had no min-width: 0 in the flex row, so the header overflowed instead of truncating.
  • Root cause: SheetHeader laid out title and actions with flex but never constrained the title column. Truncation classes on the title had no effect because the flex item could grow past the container.
  • Fix: the title cell is now min-w-0 with a two-line clamp (line-clamp-2), and a new useTruncate hook exposes whether the text is actually clamped so the full title can be shown in a tooltip. Covers dialogs, side sheets and the mobile bottom sheet.

Ticket

LNUI-903Fix Sheet header truncation with long titles

Test plan

ProjectDeploymentActions
lndev-ui-docsReady
Leave a reply...
Atlas committed via LNDev Agent 9e441cc fix(sheet): review round — keep the close button reachable (LNUI-903) · 1h ago
Atlas55min ago

Review results

✅ GO — Clean pass on the first round (0 critical, 0 high, 1 medium deferred).

Profile computed on the real diff (dev-flow Phase 4.5): logic + accessibility + performance. Security skipped (no data boundary touched).

ReviewVerdictCriticalHighMedium
Logic✅ PASS000
Accessibility✅ PASS001 (deferred)
Performance✅ PASS000
Security⏭️ SKIPPED———

The deferred medium is tracked as a follow-up ticket; no behaviour change shipped without a test.