Reviews
For youCreated
fix(sheet): header truncation with long titles [LNUI-903]1hfix(dialog): title id collision with multiple instances [LNUI-909]6hfeat(pagination): compound component API [LNUI-622]7hfeat(docs): search by prop name and enum values [LNUI-911]1dfix(progress): label rounding at 99.5 percent [LNUI-912]1dfeat(spinner): size and stroke tokens [LNUI-914]2dfeat(dialog): inert background instead of the aria-hidden walker [LNUI-780]2dfix(combobox): popover width when the trigger sits in a grid cell [LNUI-796]3dfix(toast): announce politely instead of assertively [LNUI-798]3dfeat(button): loading prop with spinner replacement [LNUI-750]4dfeat(avatar): fallback gradient derived from the user id hash [LNUI-763]5dfeat(popover): opt-in modal mode with focus containment [LNUI-766]5dfeat(scroll-area): scroll shadows via scroll-driven animations [LNUI-760]6dchore(lib): replace lodash.debounce with an in-house scheduler [LNUI-782]1wfix(button): gap collapses when an icon-only child is conditional [LNUI-797]1wfeat(table): monospace numeric cell variant [LNUI-761]8dfeat(a11y): skip-to-content link helper for app shells [LNUI-765]10dfeat(tabs): lazy mount panels with a keepMounted opt-in [LNUI-751]12dfeat(toolbar): overflow priority API [LNUI-916]2w
LNUI-622›feat(pagination): compound component API [LNUI-622]+219
OverviewGuideDiff

feat(pagination): compound component API [LNUI-622]

lndev-ui#405·main ← feat/lnui-622-pagination-compound
Description

Summary

  • New Pagination compound component: Pagination.Root, .Item, .Previous, .Next and .Ellipsis, styled with the existing button recipes.
  • A usePaginationRange hook computes the windowed page list (boundary + sibling counts) so the markup stays fully controlled by the consumer.
  • Keyboard and screen-reader behaviour follows the WAI-ARIA pagination pattern (nav landmark + aria-current="page").

Ticket

LNUI-622Ship Pagination compound component

Test plan

ProjectDeploymentActions
lndev-ui-docsReady
Leave a reply...
Atlas committed via LNDev Agent 3f0de52 feat(hooks): windowed page ranges with boundaries (LNUI-622) · 7h ago
Atlas7h ago

Review results

✅ GO — All selected reviews passed (0 critical, 0 high). The architecture HIGH was fixed in-branch and re-verified by mutation testing.

Profile computed on the real diff (dev-flow Phase 4.5): logic + performance + architecture. Security skipped (no auth surface — UI rendering only).

ReviewVerdictCriticalHighMedium
Logic✅ PASS002 (1 fixed, 1 deferred)
Performance✅ PASS001 (pre-existing, deferred)
Architecture✅ PASS (was BLOCKED, fixed)00 → fixed2 (deferred)
Security⏭️ SKIPPED———

Fixed post-review: the regression surface is now asserted by a test — a break would fail loudly instead of degrading silently.