Reviews
For youCreated
fix(sheet): header truncation with long titles [LNUI-903]1hfix(dialog): title id collision with multiple instances [LNUI-909]6hfeat(pagination): compound component API [LNUI-622]7hfeat(docs): search by prop name and enum values [LNUI-911]1dfix(progress): label rounding at 99.5 percent [LNUI-912]1dfeat(spinner): size and stroke tokens [LNUI-914]2dfeat(dialog): inert background instead of the aria-hidden walker [LNUI-780]2dfix(combobox): popover width when the trigger sits in a grid cell [LNUI-796]3dfix(toast): announce politely instead of assertively [LNUI-798]3dfeat(button): loading prop with spinner replacement [LNUI-750]4dfeat(avatar): fallback gradient derived from the user id hash [LNUI-763]5dfeat(popover): opt-in modal mode with focus containment [LNUI-766]5dfeat(scroll-area): scroll shadows via scroll-driven animations [LNUI-760]6dchore(lib): replace lodash.debounce with an in-house scheduler [LNUI-782]1wfix(button): gap collapses when an icon-only child is conditional [LNUI-797]1wfeat(table): monospace numeric cell variant [LNUI-761]8dfeat(a11y): skip-to-content link helper for app shells [LNUI-765]10dfeat(tabs): lazy mount panels with a keepMounted opt-in [LNUI-751]12dfeat(toolbar): overflow priority API [LNUI-916]2w
LNUI-911›feat(docs): search by prop name and enum values [LNUI-911]+116-16
OverviewGuideDiff

feat(docs): search by prop name and enum values [LNUI-911]

lndev-ui#398·main ← feat/lnui-911-docs-prop-search
Description

Summary

  • The docs search index now includes every component prop name and enum value, so searching sideOffset or "destructive" lands on the right API table.
  • Search hits deep-link to the exact prop row (scroll + highlight) instead of the top of the page.
  • The index is built at compile time from the same TypeScript definitions that power the prop tables — no manual sync.

Ticket

LNUI-911Search docs by prop name and enum values

Test plan

ProjectDeploymentActions
lndev-ui-docsReady
Leave a reply...
Atlas committed via LNDev Agent c4417ad feat(docs): deep-link search hits to the prop row (LNUI-911) · 1d ago
Atlas1d ago

Review results

✅ GO — Passed after one fix round: the logic HIGH found in round one was fixed in-branch and re-verified.

Profile computed on the real diff (dev-flow Phase 4.5): logic + architecture. Performance and security skipped (leaf UI change).

ReviewVerdictCriticalHighMedium
Logic✅ PASS (was BLOCKED, fixed)01 → fixed1 (fixed)
Architecture✅ PASS001 (deferred)
Performance⏭️ SKIPPED———
Security⏭️ SKIPPED———

Round-two diff was re-profiled from scratch: the fix did not widen the review surface.